fix(settings): show OAuth callback feedback on settings page#938
Merged
chubes4 merged 1 commit intoExtra-Chill:mainfrom Mar 22, 2026
Merged
Conversation
… values OAuth Callback Feedback: - Read auth_success/auth_error/provider query params on page load - Show success/error notice using WordPress Notice component - Auto-switch to Auth Providers tab after OAuth redirect - Clean up URL using history.replaceState() Auth Providers Config: - Add config_values to /auth/providers API response - Pre-populate config form fields with saved values - Sync values when provider data changes after save
saraichinwag
force-pushed
the
fix/oauth-callback-feedback
branch
from
bcb29a6 to
25ce7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When OAuth providers (Pinterest, etc.) redirect back to the settings page after authorization, users land on the page with no indication of whether the OAuth flow succeeded or failed.
The URL contains
?auth_success=1&provider=pinterestbut the React app doesn't read these params, so:Solution
This PR updates SettingsApp.jsx to:
auth_success,auth_error, andproviderin the URLhistory.replaceState()Testing
npm run buildto compile the React appFiles Changed
inc/Core/Admin/Settings/assets/react/SettingsApp.jsx- Added OAuth feedback handlinginc/Core/Admin/Settings/assets/css/settings-page.css- No changes (using standard WordPress Notice styles)